cube icon indicating copy to clipboard operation
cube copied to clipboard

feat(cubesql): Support window frame SQL push down

Open MazterQyou opened this issue 1 year ago • 2 comments

Check List

  • [x] Tests has been run in packages where changes made if available
  • [x] Linter has been run for changed code
  • [x] Tests for the changes have been added if not covered yet
  • [ ] Docs have been added / updated if required

Description of Changes Made

This PR adds push down support for window function expressions with window frames. Related test is included.

MazterQyou avatar Mar 27 '24 16:03 MazterQyou

Codecov Report

Attention: Patch coverage is 78.78788% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 61.94%. Comparing base (815be2f) to head (c662a20). Report is 107 commits behind head on master.

:exclamation: Current head c662a20 differs from pull request most recent head d6ce04d. Consider uploading reports for the commit d6ce04d to get more accurate results

Files Patch % Lines
rust/cubesql/cubesql/src/transport/service.rs 80.95% 4 Missing :warning:
...ubejs-schema-compiler/src/adapter/RedshiftQuery.ts 0.00% 2 Missing :warning:
...ubejs-schema-compiler/src/adapter/PostgresQuery.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8029       +/-   ##
===========================================
+ Coverage   47.90%   61.94%   +14.03%     
===========================================
  Files         154      351      +197     
  Lines       21034    48673    +27639     
  Branches     5422     5412       -10     
===========================================
+ Hits        10077    30151    +20074     
- Misses      10203    17770     +7567     
+ Partials      754      752        -2     
Flag Coverage Δ
cube-backend 47.90% <0.00%> (+<0.01%) :arrow_up:
cubesql 72.61% <86.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 27 '24 17:03 codecov[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 0:45am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 0:45am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 0:45am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 0:45am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 0:45am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 0:45am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 0:45am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 0:45am

vercel[bot] avatar Apr 10 '24 17:04 vercel[bot]