cube icon indicating copy to clipboard operation
cube copied to clipboard

feat(cubesql): Support Skyvia date granularities

Open MazterQyou opened this issue 3 years ago • 1 comments

Check List

  • [x] Tests has been run in packages where changes made if available
  • [x] Linter has been run for changed code
  • [x] Tests for the changes have been added if not covered yet
  • [x] Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

This PR adds rewrites to support Skyvia date granularities. It also adds related tests.

MazterQyou avatar Jul 04 '22 06:07 MazterQyou

Codecov Report

Base: 40.54% // Head: 60.09% // Increases project coverage by +19.54% :tada:

Coverage data is based on head (741f858) compared to base (fb6fade). Patch coverage: 95.30% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4844       +/-   ##
===========================================
+ Coverage   40.54%   60.09%   +19.54%     
===========================================
  Files         144      280      +136     
  Lines       19337    36777    +17440     
  Branches     4900     4900               
===========================================
+ Hits         7841    22100    +14259     
- Misses      11191    14372     +3181     
  Partials      305      305               
Flag Coverage Δ
cube-backend 40.54% <ø> (ø)
cubesql 81.76% <95.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/mod.rs 64.23% <ø> (ø)
...besql/cubesql/src/compile/rewrite/rules/members.rs 97.93% <ø> (ø)
...cubesql/cubesql/src/compile/rewrite/rules/split.rs 95.56% <95.27%> (ø)
rust/cubesql/cubesql/src/compile/engine/udf.rs 86.52% <100.00%> (ø)
rust/cubesql/cubesql/src/compile/parser.rs 96.87% <0.00%> (ø)
...ile/engine/information_schema/postgres/pg_roles.rs 94.66% <0.00%> (ø)
...cubesql/cubesql/src/compile/test/rewrite_engine.rs 0.00% <0.00%> (ø)
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 69.71% <0.00%> (ø)
...nt/src/models/v1_load_request_query_filter_item.rs 0.00% <0.00%> (ø)
...nformation_schema/redshift/svv_external_schemas.rs 94.44% <0.00%> (ø)
... and 130 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 04 '22 06:07 codecov[bot]