#29 - SSR ErrorComponent

Open DPr00f opened this issue 8 years ago • 4 comments

As explained on #29 the Error component wasn't being rendered on the server side. This PR fixes it.

Oct 30 '17 17:10 DPr00f

Oh, I'll fix that today.

Oct 31 '17 11:10 DPr00f

Codecov Report

Merging #43 into master will increase coverage by 0.16%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   94.17%   94.33%   +0.16%     
==========================================
  Files           5        5              
  Lines         103      106       +3     
  Branches       31       31              
==========================================
+ Hits           97      100       +3     
  Misses          6        6

Impacted Files	Coverage Δ
src/withJob.js	`91.93% <100%> (+0.41%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f99572...a26f579. Read the comment docs.

Nov 01 '17 17:11 codecov[bot]

Hey @ctrlplusb will this be considered at all?

Will be using this in production soon, would be nice to have this fixed.

Feb 06 '18 14:02 DPr00f

Hi @ctrlplusb @DPr00f ! Thanks for reporting this issue. I ran into the same thing with the error component on SSR. Any updates if this is going to be resolved? Many thanks for all your work on this library.

Feb 12 '20 21:02 grahamd711