Fredrick Brennan

Results 633 comments of Fredrick Brennan

If you're planning on a more thorough fix to also allow resizing the window (i.e. deprecating the `SlackUI::add_message` and `SlackUI::add_history` functions) I won't continue working on my commit which would...

Alright 👍 I agree that we should have a new Chat messages structure, but I need more time to think about what that should look like :)

No, it won't be enough because some "wide" characters (in terms of bytes) are not also "wide" (in terms of their actual graphical representation). I already converted back and forth...

We're dealing with a monospaced grid here so if some multibyte characters require 2 columns and others 1, if our program is not aware of this we still get overflows...

OK. Here's my patch which solves the weak case. ```diff --git a/src/SlackUI.cpp b/src/SlackUI.cpp index 9aace87..3198be4 100644 --- a/src/SlackUI.cpp +++ b/src/SlackUI.cpp @@ -1,5 +1,7 @@ #include "SlackUI.hpp" +std::wstring_convert u32conv; + static...

WeeChat uses `wcswidth`: https://github.com/weechat/weechat/blob/master/src/core/wee-utf8.c#L521

I've discovered that there is an alternative, but it requires changing the way that the UI works. We could make #13 mandatory - no more borders - and either permanently...

Yeah the guy on SO was all like "you shouldn't use wcwidth because it can be out of date" or "wrong" on certain dead platforms. (Solaris? who cares? :joy: )...

I think it's a good idea to get this issue fixed first because surely other people will notice it...I for one did not find this project due to any publicity,...

Hey: Sorry I hadn't been able to get back to you until now. I wrote a library in Rust at my job that would easily solve this problem as part...