Fredrick Brennan

Results 633 comments of Fredrick Brennan

No problem, glad to know it's not totally dead :-) I think you should nominate someone but only you can decide that. I'll maintain a fork for a little while...

I'm not really stoked about the fact you don't distribute an AppImage, which while perhaps not standard when @probonopd opened this, now is. Honestly I'd say since 2018 the responsibility...

I really hope this can be merged soon, MFEKglif is still stuck on imgui-rs 0.7.0 and the branch has diverged a whole bunch yet again, I'd like to be able...

I really really don't think it's a problem to have `vcpkg` required in this PR, then another PR to add _both_ the `use-pkg-config` and `use-vcpkg`. It won't matter on Linux...

Oh, that's not really a major problem. This commit doesn't touch CI. You need to add something like `friendlyanon/setup-vcpkg@v1` (https://github.com/friendlyanon/setup-vcpkg) then add a command like this ```yaml - if: matrix.platform...

Sorry, I know you are waiting or him to reply, I just want this fixed :-P

Oh, I'm sorry, I didn't understand fully the CI problem. I think you need this also: https://crates.io/crates/cargo-vcpkg, which claims to interoperate with `vcpkg` Then in `Cargo.toml`: ```toml [package.metadata.vcpkg.target] x86_64-pc-windows-msvc =...

Also I am doubting a little bit that the Windows GitHub CI comes with vcpkg. The opencv-rust project, well maintained, installs it themselves: https://github.com/twistedfall/opencv-rust/blob/master/.github/workflows/opencv-rust.yml https://github.com/twistedfall/opencv-rust/blob/master/ci/install-windows-vcpkg.sh

RustDesk project also installs own `vcpkg`. Why do we think `vcpkg` globally included? https://github.com/rustdesk/rustdesk/blob/b3e3f6151d537a009dbbb8ef695c6fe13fd45527/.github/workflows/ci.yml#L86 Their `ci.yml` also mentions `$VCPKG_ROOT` envvar.

Oh, I just found something interesting, even if you are right about vcpkg bundling with Windows GH CI, there is this in the `vcpkg` crate docs: ```rust //! # Environment...