Using latest version of Moments with GADMA

[dmacguigan]

Hello,

I am attempting to set up a model with the Moments engine, but I'm running into trouble with poor documentation. It seems GADMA is stuck using an older version of Moments, and some functions like moments.Manips.split_1D_to_2D are deprecated in the latest version.

For example, from the Moments documentation (https://momentsld.github.io/moments/sfs/sfs.html):

Previous versions of moments required calling functions such as moments.Manips.split_1D_to_2D(fs, n0, n1) or moments.Manips.split_3D_to_4D_2(fs, n0, n1). The new API (fs.split(idx, n0, n1)) wraps the different split functions in moments.Manips so that we don’t need to worry about picking the correct split function.

Is it possible to use the latest version (1.4.2) of Moments with GADMA?

Thanks, Dan

[noscode]

Hi @dmacguigan,

Thank you very much for pointing that out. I have seen that moments got new API in the latest version, but I have not checked if GADMA works with it. I do not think old API is deprecated, at least yet. According to the code in the repository, functions like split_1D_to_2D should still be successfully read.

I will check if GADMA works with the new version of moments and come back to you.

Best regards, Ekaterina

[dmacguigan]

Thanks for taking a look at this @noscode! It seems the newer functions like moments.Spectrum.split work with GADMA. I just wish they had kept the documentation online for the older functions like split_1D_to_2D. I had to go into their source code to understand how these functions work.

[noscode]

Okay, I see. Anyway, I will update GADMA interface to align with the new moments version in the next release.