Carroll Vance
Carroll Vance
Hey @Drvi, we just merged gRPCClient 1.0.0 and moved it to JuliaIO https://github.com/JuliaIO/gRPCClient.jl Codegen is the last outstanding issue we need to resolve before we can register the package.
Hey @tanmaykm, I'm going to work on getting this in a better state with test coverage and documentation this weekend. As far as actually getting this merged and the release...
> Since this creates code wrapped inside of a module, it would be necessary to run `import gRPCClient` as well. Doesn't it generate two files, one with and without a...
It's relatively simple to put the`using gRPCClient` in the right place afaik, but we do have to tell `ProtoBuf.jl` what to include. In the future we may also register a...
@johroj I think it might be easy to get carried away with over-engineering this. I tried as best I could to define an interface that isn't cluttered/overly specific but can...
@tanmaykm currently on 1.12 and nightly some of the tests are failing due to: 1. https://github.com/JuliaLang/julia/issues/58780 behavior of `@allocated` seems to have changed breaking two tests 2. JET says `optimization...
@johroj allowing for imports to be conditional on the types being generated (ie only trigger `import gRPCClient` if there is `>= 1 ServiceType`) is now implemented. It's done in a...
@tanmaykm I rebased + cleaned up commit history and ran the gRPCClient.jl test suite after re-running code generation. Looks good to me.
There are two things I should address right off the bat. ### Package Name Obviously just adding a 2 to an existing package name isn't ideal. I wrote this package...
> “starts with an upper-case letter” is a hard rule, notwithstanding a handful of existing packages that slipped through before this was enforced. As suggested on Slack by Ronny, we...