Release version 1.0.6

[csernazs]

• release_notes: add release note about the blocking httpserver
• Version bump to 1.0.6
• CHANGES.rst: add release notes for 1.0.6

[codecov[bot]]

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3091608). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head b9437ab differs from pull request most recent head 4310215. Consider uploading reports for the commit 4310215 to get more accurate results

@@            Coverage Diff            @@
##             master     #177   +/-   ##
=========================================
  Coverage          ?   94.90%           
=========================================
  Files             ?        4           
  Lines             ?      550           
  Branches          ?        0           
=========================================
  Hits              ?      522           
  Misses            ?       28           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[csernazs]

@matez0

I'm about to release the next version, 1.0.6 with your blocking httpserver implementation and my minor fixes on top of it (renamings, doc fixes, kwargs fixes; no functional changes). I have also created a howto you can access here.

If you want you can take a look at the commits, you can find them here. There are other CI-related commits which are unrelated to your code.

If you find any issue, please write it to a comment or create a new issue or open a PR for it.

Thanks, Zsolt

[matez0]

Hi Zsolt,

I am ok with the changes. Only one thing I could not understand is that why the default host and port constants cannot stay in the base class.

I made a comment that it is practical to check the errors after stopping the server in a fixture. And this is needed because the dispatch can also register assertions. Actually one unit test is explicitly doing this, but a better place would be where the server is stopped anyway.

Thanks, Zoli

On Mon, Sep 5, 2022, 23:33 Zsolt Cserna @.***> wrote:

@matez0 https://github.com/matez0

I'm about to release the next version, 1.0.6 with your blocking httpserver implementation and my minor fixes on top of it (renamings, doc fixes, kwargs fixes; no functional changes). I have also created a howto you can access here https://pytest-httpserver.readthedocs.io/en/latest/howto.html#running-httpserver-in-blocking-mode .

If you want you can take a look at the commits, you can find them here https://github.com/csernazs/pytest-httpserver/compare/902801c82804be1097a19d411e877e2dc1cb526d...master. There are other CI-related commits which are unrelated to your code.

If you find any issue, please write it to a comment or create a new issue or open a PR for it.

Thanks, Zsolt

— Reply to this email directly, view it on GitHub https://github.com/csernazs/pytest-httpserver/pull/177#issuecomment-1237470984, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6GEAP3FQDN22KEBAGNPVDV4ZRK7ANCNFSM6AAAAAAQFIMAZ4 . You are receiving this because you were mentioned.Message ID: @.***>

[csernazs]

Thanks for looking at the changes!

For the default host and port in the base class: as **kwargs have been removed, I had to provide some defaults for them in the derived class. And this code is not valid in python3:

class Base:
    FOOBAR = 123


class Subclass(Base):
    def __init__(self, foobar=FOOBAR):
        self.foobar = foobar

It fails with NameError: name 'FOOBAR' is not defined.

Also, the user can change the class attribute, this is documented here.

For check_assertions, I'll update the example and the howto, thanks.

[matez0]

Thanks for the explanation and the change.

On Wed, Sep 7, 2022, 22:02 Zsolt Cserna @.***> wrote:

Thanks for looking at the changes!

For the default host and port in the base class: as **kwargs have been removed, I had to provide some defaults for them in the derived class. And this code is not valid in python3:

class Base: FOOBAR = 123

class Subclass(Base): def init(self, foobar=FOOBAR): self.foobar = foobar

It fails with NameError: name 'FOOBAR' is not defined.

Also, the user can change the class attribute, this is documented here https://pytest-httpserver.readthedocs.io/en/latest/howto.html#class-attributes .

For check_assertions, I'll update the example and the howto, thanks.

— Reply to this email directly, view it on GitHub https://github.com/csernazs/pytest-httpserver/pull/177#issuecomment-1239815654, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6GEAIIIEZZTX37RA6VJB3V5DYEBANCNFSM6AAAAAAQFIMAZ4 . You are receiving this because you were mentioned.Message ID: @.***>

[csernazs]

@matez0 FYI: I have released 1.0.5 now with your code.