arbbot icon indicating copy to clipboard operation
arbbot copied to clipboard

Add HitBTC, Cryptopia and some other exchange IDs

Open OlegVic opened this issue 8 years ago • 8 comments

OlegVic avatar Feb 03 '18 12:02 OlegVic

Do you have any plans to contribute any of these exchanges back? :-) I prefer to first add a few more exchange backends before adding more. It seems kind of unfair for me to just keep adding IDs to my project for which I won't see any other code contributions...

cryptoeax avatar Feb 04 '18 00:02 cryptoeax

Nice, thank you! I will try to review this PR and also test it out in the next few days...

cryptoeax avatar Feb 05 '18 14:02 cryptoeax

How well is HitBTC working for you currently?

cryptoeax avatar Feb 05 '18 14:02 cryptoeax

Not good, many things in CCXT adapter not compatable. And i build my own branch with updated CCXT. About HitBTC you can see code in my profile

OlegVic avatar Feb 05 '18 16:02 OlegVic

Can you please submit a PR for the CCXTAdapter fixes you made too? This one only includes https://github.com/cryptoeax/arbbot/pull/148/commits/8ad9a4b7672b09856f7a025f294635f7838f6653 as far as I can see. Thanks!

cryptoeax avatar Feb 08 '18 15:02 cryptoeax

(I'd like to test the exchange before merging it, so having something that works would be really helpful.)

cryptoeax avatar Feb 08 '18 15:02 cryptoeax

How well does Cryptopia work? I really wish you didn't mix multiple exchange backends in the same PR. This makes it impossible to merge your PR as is without me spending weeks to test both HitBTC and Cryptopia and make sure they are both bug free. :-( Just to make sure you aren't expecting a fast turn around, each exchange being tested takes quite a long time, and keeping them in separate PRs would have helped me merge the one that is ready first.

cryptoeax avatar Feb 09 '18 15:02 cryptoeax

Please avoid adding any other features to this PR. If you have other changes to contribute, please spend some time to make separate PRs for them. Thanks!

cryptoeax avatar Feb 09 '18 15:02 cryptoeax