Henry

Results 168 comments of Henry

It's super odd because non of the lock contention code should take any time.. :-| We could rewrite the number acquisition code with timeouts such that the renders without an...

Hmm... thanks for reporting. The invite flow was refactored a bit prior to lunch and it seems like the fallback form (to manually supply the ssb public key) fell of...

Tangential but how i noticed this: We might also want a check on the CI so that we don't check in the development version of tailwind CSS.

It will be possible when the improved errors PR is merged.

Hm... just for understanding is the title, language or pinned name duplicated? I guess there should be a better constrained on the db to protect against duplicates. For background: Initially...

I was looking a bit at sqlite's docs and don't think it's possible to add a constraint that would protect. The most simplest thing we should do then is adding...

Yes, totally agree. I think our test cases leaked into the wild/first release. I'd wager to collect #213, #161 and this issue to make this feature more coherent and useful.

`urlToNotice` still needs to be fixed to not use the hardcoded language.

For invites we already track this so we need to copy this info to the member and change the schema a bit. For banned people we need to change the...

Hmm.. yea that is possible but seems a bit messy. We dont support members changing their pubkeys so it _might_ be fine but idk... It feels very similar to https://github.com/ssb-ngi-pointer/rooms2/issues/8,...