crowdin-api-client-ruby icon indicating copy to clipboard operation
crowdin-api-client-ruby copied to clipboard
verified publisher icon crowdin

Add Bundle API - mark some parameters as required

Open andrii-bodnar opened this issue 3 years ago • 4 comments

Add Bundle API reference

https://github.com/crowdin/crowdin-api-client-ruby/blob/18f977eeb68d30baed7fe95da4545caa937dd3d2/lib/crowdin-api/api_resources/bundles.rb#L18

The following parameters are required by API - name, format, sourcePatterns, exportPattern.

It should be marked as required in the code also and the corresponding error should be raised in case of some parameter absence. (raise_parameter_is_required_error)

andrii-bodnar avatar Sep 21 '22 11:09 andrii-bodnar

@andrii-bodnar : Can you assign this issue to me? I will get the work started on this

sabarish98 avatar Oct 25 '22 18:10 sabarish98

@sabarish98 sure, thank you!

andrii-bodnar avatar Oct 25 '22 18:10 andrii-bodnar

@andrii-bodnar : Raised https://github.com/crowdin/crowdin-api-client-ruby/pull/27 for this. I believe this was the requirement, feel free to let me know if otherwise

sabarish98 avatar Oct 25 '22 19:10 sabarish98

@sabarish98 thank you, I will review it tomorrow

andrii-bodnar avatar Oct 25 '22 19:10 andrii-bodnar