crowbar
Tempest ui
Wasn't @vuntz saying that the tempest UI parts will be removed?
It's even better if we can fix it. I was going for removal since it was easier and the UI is not critical.
As you are changing the views anyway you can directly use the new hash syntax key: "value", and you should use double quotes instead of single quotes.
Do not merge for now; I want additional testing (not just code review) to be sure the UI is fully working.
So I tested the PR and the results are always in failed state. From the production.log:
I, [2016-02-10T13:38:42.806335 #25172:0x007f2478d868c0] INFO -- Rendered shared/_footer.html.haml (0.2ms)
I, [2016-02-10T13:38:42.806773 #25172:0x007f2478d868c0] INFO -- Completed 200 OK in 439ms (Views: 48.8ms | ActiveRecord: 0.3ms)
D, [2016-02-10T13:38:43.025808 #25809:0x007f2478d868c0] DEBUG -- Acquire tempest lock enter as uid 486
D, [2016-02-10T13:38:43.025963 #25809:0x007f2478d868c0] DEBUG -- Acquiring tempest lock
D, [2016-02-10T13:38:43.026011 #25809:0x007f2478d868c0] DEBUG -- Lock /opt/dell/crowbar_framework/tmp/tempest attempt 1
D, [2016-02-10T13:38:43.026071 #25809:0x007f2478d868c0] DEBUG -- Acquire tempest lock exit: #<File:/opt/dell/crowbar_framework/tmp/tempest>
D, [2016-02-10T13:38:43.044790 #25809:0x007f2478d868c0] DEBUG -- Release tempest lock enter: #<File:/opt/dell/crowbar_framework/tmp/tempest>
D, [2016-02-10T13:38:43.044877 #25809:0x007f2478d868c0] DEBUG -- Release tempest lock exit
I, [2016-02-10T13:38:43.044922 #25809:0x007f2478d868c0] INFO -- test run e18f3909-cae2-4e44-affb-a20f3ff2fa74 complete, status 'failed'
Also when i failed state and clicking on it and then on the Raw XML link, the page looks really ugly and is just showing:
This page contains the following errors:
error on line 1 at column 1: Document is empty
Below is a rendering of the page up to the first error.
Without any menu/back button/whatever/.... (because I guess it's chrome standard error page for showing xml so not much todo here)
To summarize: -1