crowbar
Add guard support
I would prefer if we integrate it into https://github.com/crowbar/crowbar/blob/master/Guardfile. Then we have all the guard code at one place.
I would prefer if we integrate it into https://github.com/crowbar/crowbar/blob/master/Guardfile. Then we have all the guard code at one place.
but that will not work anymore if you just clone this repo... only works if you set up a development environment with the barclamps folder that has this repo here, which not everybody does.
@rsalevsky I would prefer the opposite, because they have no goals or code in common.
There are two reasons why I think it is better if we do it in the crowbar repo:
- We save the duplicated code for the gem definition.
- You just need to run one command to sync to the remote and see the results. @MaximilianMeister I think if you do crowbar development then you should use also the dev setup. Otherwise I'm not sure how the code should be tested.
If you get another +1 feel free to merge it I don't want to block merging this if it helps making faster progress.
We save the duplicated code for the gem definition.
I agree that's a benefit, but only a very small one which is outweighed by the other considerations below:
You just need to run one command to sync to the remote and see the results.
This is mixing two completely different things. One is syncing to a remote server, which is useful for testing deployed code, and the other is running unit tests directly from within a development environment. Sometimes you might want to do one, sometimes the other, and sometimes both at the same time. So it doesn't make sense to couple them together.
Other reasons:
- It must be possible to update the code and the corresponding Guardfile in a single PR, for example if you add a new subdirectory or filetype which is not covered by the existing patterns. This is pretty important.
- It should be possible to quickly check out just
crowbar-coreand hack on it without requiring other repos. This is not so important but still worth having.