function-sdk-go icon indicating copy to clipboard operation
function-sdk-go copied to clipboard

Rename proto/v1beta1/Resource.Resource field to improve clarity

Open pedjak opened this issue 2 years ago • 2 comments

There is a struct Resource containing field Resource. The doc says it is the json representation of the given resource. Could we rename the field to reflect that?

pedjak avatar Sep 29 '23 10:09 pedjak

Any suggestions on naming?

In a way I think the Resource field is accurate, it's more that the message it lives in represents not only a resource but its associated properties - e.g. connection details and readiness. So renaming the Resource message could be another option.

negz avatar Sep 30 '23 01:09 negz

Any suggestions on naming?

Since it contains the resource content encoded in json, perhaps we can call it JSONData?

pedjak avatar Oct 04 '23 10:10 pedjak