crossplane
chore: added observedGeneration to the Ready and Sync condition
Description of your changes
Today is pretty impossible to know when a managed resource is fully reconciled after an update.
On creation we can check the Ready and Sync conditions to be True but on updates we never know if what we are seeing is the actual or the previous state.
Imagine we are updating an RDS cluster (long running async update) and by looking to the CR we cant tell if the update is done, in progress or if the controller is actually dead.
This PR adds the observedGeneration to the Ready and Sync conditions in the main reconcile loop since it was introduced with #633
Related with: https://github.com/crossplane/crossplane/issues/4695 https://github.com/crossplane/crossplane/issues/4655
I have:
- [x] Read and followed Crossplane's contribution process.
- [x] Run
earthly +reviewableto ensure this PR is ready for review. - [ ] Added or updated unit tests.
- [ ] Linked a PR or a docs tracking issue to document this change.
- [ ] Added
backport release-x.ylabels to auto-backport this PR.
Need help with this checklist? See the cheat sheet.
@pintonunes Hey, this looks great and like something we could really use in our team! But I guess the change set needs some test coverage, and that this may be the reason why the PR hasn't progressed yet @turkenh?
