azure-devops-pull-request-hub icon indicating copy to clipboard operation
azure-devops-pull-request-hub copied to clipboard

Don't reuse the already loaded repositories

Open davesmits opened this issue 3 years ago • 8 comments

An attempt to get #241 fixed

I noticed two faulty behaviors:

  • the one described in the bug #241
  • When you add a new project in the filter bar; get those repositories; remove the proejct again. The repositories from the removed project stay visible

This change should reset the items in the state instead of just keep adding more and more

DISCLAIMER: So far not been able to test it locally.. which makes it a bit of a risky change. Maybe a maintainer can give me a hand?

davesmits avatar Jan 04 '23 17:01 davesmits

@davesmits thanks for raising this PR, I will try to look into it in the following days. It's breaking the build due the invalid variable declaration.

cribeiro84 avatar Jan 20 '23 18:01 cribeiro84

I gave it another try but don't understand what is wrong and build results in missing file. So hope you want to help image

davesmits avatar Jan 20 '23 19:01 davesmits

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jan 30 '23 19:01 sonarqubecloud[bot]

@cribeiro84 want to give it another look? should be building now again

davesmits avatar Jan 30 '23 19:01 davesmits

@cribeiro84 anything I can to do to get this merged or fixed?

davesmits avatar Sep 10 '24 10:09 davesmits

@cribeiro84 anything I can to do to get this merged or fixed?

was this tested on your environment? Did you see any impact?

cribeiro84 avatar Sep 10 '24 12:09 cribeiro84

I will give it a renew try this weekend. not sure where I left it off.

davesmits avatar Sep 11 '24 09:09 davesmits