saml icon indicating copy to clipboard operation
saml copied to clipboard

Error in schema.go

Open marcidelux opened this issue 3 years ago • 7 comments

Hi !

There is a small error in schema.go at line 767 : err := etreeutils.TransformExcC14n(el, canonicalizerPrefixList) The TransformExcC14n requires 3 argument, but only 2 were given. When I set the comments to false it was working fine. Can you please make a quick fix, otherwise I have to do an ugly monkey fix solution and that's bad for all of us :D Thank you very much for your work.

marcidelux avatar Sep 25 '22 16:09 marcidelux

Same issue here.

mikey923 avatar Sep 26 '22 16:09 mikey923

Same issue here. Maybe the lastest version(v0.4.8) depend github.com/russellhaering/goxmldsig(v1.1.1), it should support v1.2.0

yanlong-turingvideo avatar Sep 28 '22 03:09 yanlong-turingvideo

any update?

ariefsn avatar Oct 04 '22 10:10 ariefsn

yeah same issue here

stephen-digicert avatar Oct 14 '22 17:10 stephen-digicert

Hi!

I told that it will be ugly, but I made a monkey patch: Place this in to the go.mod file before requre part: replace github.com/crewjam/saml v0.4.8 => github.com/marcidelux/saml v0.4.10 Yeah I know the version number is bigger, but it was necessary when I was messing with it, doesn`t matter it will be removed when the problem is fixed.

marcidelux avatar Oct 17 '22 09:10 marcidelux

Another possible workaround is to stick with goxmldsig v1.1.1 for now, until this is addressed.

anthonyalberto avatar Oct 28 '22 14:10 anthonyalberto

@crewjam , same issue here. Could you please fix it and release?

greenpau avatar Nov 06 '22 17:11 greenpau