Resolved Searching Licensed Bug
Fixes
- Fixes #228 by @zackkrida
Description
This pull request addresses the issue where certain sources on the Creative Commons search platform were not correctly filtering results based on CC licenses. Users might have inadvertently accessed non-CC licensed works due to this issue.
The sources affected include:
- Soundcloud, Wikimedia Commons, and Google Images – where filtering for CC-licensed content was not applied correctly.
- ccMixter – which was entirely broken and did not return any results.
The fix ensures that all these sources now return only CC-licensed content, or function properly in the case of ccMixter.
Technical details
- The URL structures for the affected sources were updated to apply the correct CC license filtering.
- Adjustments were made to the API integration to ensure proper data retrieval from each source.
Tests
- Verified that Soundcloud, Wikimedia Commons, and Google Images now correctly filter results to only show CC-licensed works.
- Tested ccMixter to confirm it returns results as expected.
- Ensured that other unaffected sources continue to function correctly.
Screenshots
https://github.com/user-attachments/assets/e975125c-26b8-4b75-8362-2c804057654b
Checklist
- [x] My pull request has a descriptive title.
- [x] My pull request targets the default branch of the repository (
mainormaster). - [x] My commit messages follow [best practices][best_practices].
- [x] My code follows the established code style of the repository.
- [x] I added or updated tests for the changes I made.
- [x] I added or updated documentation (if applicable).
- [x] I verified the project locally and ensured there are no visible errors.
Deploy Preview for cc-search-portal ready!
| Name | Link |
|---|---|
| Latest commit | a439b8eb608d1176a853b1c5ba905d609f75f7db |
| Latest deploy log | https://app.netlify.com/sites/cc-search-portal/deploys/6720326aadc19700088435ca |
| Deploy Preview | https://deploy-preview-259--cc-search-portal.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
This pr fixes this issue #250
This pr fixes thi
This pr fixes this issue #250
but when I added this pr at that time there was no mentioned pr there @Netacci
I'm just referencing the issue here @crocmons