search icon indicating copy to clipboard operation
search copied to clipboard

refactors engine buttons

Open JennySimen opened this issue 3 years ago • 5 comments

Fixes

Fixes #159 by @JennySimen and #166 by @dikehprosper

Description

This PR changes the structure of the engine buttons in order to improve accessibility. The different HTML elements used to create the engine buttons are removed and only the <button> tag is used. The unused CSS classes are removed as well.

Screenshots

Screen Shot 2022-11-11 at 17 51 47

Checklist

  • [x] My pull request has a descriptive title (not a vague title like Update index.md).
  • [x] My pull request targets the default branch of the repository (main or master).
  • [x] My commit messages follow best practices.
  • [x] My code follows the established code style of the repository.
  • [ ] I added or updated tests for the changes I made (if applicable).
  • [ ] I added or updated documentation (if applicable).
  • [x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

JennySimen avatar Nov 11 '22 17:11 JennySimen

@JennySimen can you get the branch up to date and I'll review it further! Thanks! ❤️

possumbilities avatar Nov 18 '22 20:11 possumbilities

@possumbilities right away

JennySimen avatar Nov 18 '22 20:11 JennySimen

Hi @possumbilities, please I just updated the branch.

JennySimen avatar Nov 18 '22 22:11 JennySimen

@JennySimen All seems sound, looks like that last PR merge made this out of date again, if you can do one last update we'll move forward with it after a final test on this end. ❤️

possumbilities avatar Nov 23 '22 21:11 possumbilities

@possumbilities on it

JennySimen avatar Nov 25 '22 10:11 JennySimen

@possumbilities I have updated the PR

JennySimen avatar Nov 30 '22 11:11 JennySimen

@JennySimen Great work!

Something I've noticed, it might be worthwhile to incorporate the work from #162 from @ImaJin14 so that they don't conflict with each other, and I can then give credit to both of you on this PR as combined work?

@ImaJin14 You OK with that?

possumbilities avatar Dec 05 '22 15:12 possumbilities

@possumbilities I agree

JennySimen avatar Dec 05 '22 15:12 JennySimen

I agree @possumbilities

@JennySimen please go ahead and implement the changes in #162

ImaJin14 avatar Dec 05 '22 15:12 ImaJin14

@possumbilities changes have been added on this branch

JennySimen avatar Dec 09 '22 22:12 JennySimen

Closing with the acceptance of:

  • #206

possumbilities avatar Mar 15 '23 22:03 possumbilities