search icon indicating copy to clipboard operation
search copied to clipboard

[Feature] Refactor Search Engine buttons

Open JennySimen opened this issue 3 years ago • 11 comments

Problem

The current implementation of the search engine buttons needs refactoring in order to provide a more standard and stable implementation.

This should also provide better fix for #155. Below is the current structure of the search engine buttons

<div class="engine">
       <div class="engineButton">
	  <button onclick="setEngine(this)" name="engine" value="ccmixter" id="ccmixter"></button>
       </div>
      <div class="engineDesc"><label for="ccmixter"><strong>ccMixter</strong><br/>Music</label></div>
</div>

Description

Create minimal <button> elements for each search engine AND they should contain inner text: <button>engineName</button>.

Reference this comment as guide.

Alternatives

Implementation

  • [ ] I would be interested in implementing this feature.

JennySimen avatar Oct 31 '22 15:10 JennySimen

@possumbilities please if anything needs to be added to this issues, do let me know so I can update the issues description.

JennySimen avatar Oct 31 '22 15:10 JennySimen

If this gets triage I'll love to work on it... Please assign it to me @possumbilities ....

ImaJin14 avatar Oct 31 '22 16:10 ImaJin14

Awesome issue raised on #155 @JennySimen
@possumbilities I would be interested in working on this issue can you please assign me?

mbonamensa avatar Oct 31 '22 16:10 mbonamensa

@ImaJin14 @mbonamensa I think we could assist and encourage those without contributions to pick this up and work on it 🙂

JennySimen avatar Oct 31 '22 17:10 JennySimen

@JennySimen Yeah sure, I'll share this in Slack and if after a while no one has, I'd love to work on it.

mbonamensa avatar Oct 31 '22 17:10 mbonamensa

@mbonamensa If no one takes this issue, we could contribute together. It would be fun working with someone else on this issue. 🙂

JennySimen avatar Oct 31 '22 17:10 JennySimen

@JennySimen Sure! Happy to work with you on this.

mbonamensa avatar Oct 31 '22 17:10 mbonamensa

@JennySimen @mbonamensa Either of you still interested in working on this?

possumbilities avatar Nov 04 '22 15:11 possumbilities

@possumbilities yes I am

JennySimen avatar Nov 04 '22 15:11 JennySimen

@JennySimen how's it going? Where can I help?

mbonamensa avatar Nov 05 '22 07:11 mbonamensa

@mbonamensa it's going quite well, soon creating a PR for the issue

JennySimen avatar Nov 08 '22 15:11 JennySimen

Resolved in new site merge: https://github.com/creativecommons/search/pull/206

possumbilities avatar Mar 04 '24 15:03 possumbilities