cc-resource-archive icon indicating copy to clipboard operation
cc-resource-archive copied to clipboard

[Bug] Language filter overlapping with Resource cards

Open Xaid-vfx opened this issue 3 years ago • 5 comments

Description

After the new code merges, the languages are overlapping with the resource card after clicking see all.

Reproduction

  1. Go to https://resources.creativecommons.org/all/
  2. See error

Expectation

A margin/padding can provided which can fix this overlapping.

Screenshots

See the Language filter

Screenshot 2023-04-01 at 6 05 33 PM

Environment

  • Device: Laptop
  • OS: MacOs
  • Browser: Firefox
  • Other info: All resolutions

Resolution

  • [x] I would be interested in resolving this bug.

Xaid-vfx avatar Apr 01 '23 12:04 Xaid-vfx

@Xaid-vfx Could you share environmental details such as screen resolution, browser etc ? it is working completely fine on my pc image

Lakshay-Pruthi avatar Apr 01 '23 13:04 Lakshay-Pruthi

@Lakshay-Pruthi I think the above issue persists in Firefox for all resolutions. It works fine on Chrome and Safari. Regardless of browser, I think it would be appropriate to provide some space between Cards and Filter. Even in chrome, the space is too little. A little margin would fix the issue for all browsers.

For example: This is on iPhone 14 Safari browser:

Xaid-vfx avatar Apr 01 '23 13:04 Xaid-vfx

Hey @Xaid-vfx ,

Since "Submit a resource" link is added, I don't think this issue persists. I might be wrong though. Lemme know your thoughts :)

yogeyyy avatar Mar 14 '24 06:03 yogeyyy

@TimidRobot Can we close this issue now?

Ajay-singh1 avatar Jul 31 '24 11:07 Ajay-singh1

@possumbilities The issue gets resolved by the PR #316 and can be closed successfully 🙌

Murdock9803 avatar Aug 11 '24 01:08 Murdock9803