CraueFormFlowBundle icon indicating copy to clipboard operation
CraueFormFlowBundle copied to clipboard

Optional persistence of step data on flow back transition

Open linxlad opened this issue 9 years ago • 19 comments

Added optional class property and logic for step data persistence if the flow is transitioned backwards. If persistence on backwards transition is enabled and the current request transition is 'back' then persist the current step data to storage.

linxlad avatar Jun 03 '16 11:06 linxlad

Coverage Status

Coverage decreased (-1.1%) to 98.626% when pulling 12f3046569f73db61e4daf6d7a84faaa67459732 on linxlad:master into 551482eadb8b5d9cacda46a8afa8108ae9e08cdb on craue:master.

coveralls avatar Jun 03 '16 11:06 coveralls

Please see gif recording of this PR in action: http://cl.ly/gMHA

linxlad avatar Jun 03 '16 12:06 linxlad

Coverage Status

Coverage decreased (-2.1%) to 97.651% when pulling 3ef1d6089f2441811919f5b672e9ad56c153fb48 on linxlad:master into 551482eadb8b5d9cacda46a8afa8108ae9e08cdb on craue:master.

coveralls avatar Jun 03 '16 12:06 coveralls

Hi, great! :) I think you should also add a "set" and "is" method for the persistOnBackTransition variable, like revalidatePreviousSteps has setRevalidatePreviousSteps and isRevalidatePreviousSteps

Filoz avatar Jun 03 '16 12:06 Filoz

Coverage Status

Coverage decreased (-2.1%) to 97.651% when pulling 0e3e148c2f13e55f5aaf50b8eae3469ae4e21182 on linxlad:master into 551482eadb8b5d9cacda46a8afa8108ae9e08cdb on craue:master.

coveralls avatar Jun 03 '16 12:06 coveralls

Coverage Status

Coverage decreased (-2.1%) to 97.651% when pulling 0e3e148c2f13e55f5aaf50b8eae3469ae4e21182 on linxlad:master into 551482eadb8b5d9cacda46a8afa8108ae9e08cdb on craue:master.

coveralls avatar Jun 03 '16 12:06 coveralls

@Filoz Thanks for the suggestion. I have added those methods :)

linxlad avatar Jun 03 '16 12:06 linxlad

Coverage Status

Coverage decreased (-2.1%) to 97.651% when pulling 0e3e148c2f13e55f5aaf50b8eae3469ae4e21182 on linxlad:master into 551482eadb8b5d9cacda46a8afa8108ae9e08cdb on craue:master.

coveralls avatar Jun 03 '16 12:06 coveralls

Coverage Status

Coverage decreased (-1.9%) to 97.847% when pulling b819d27854e4cf6b154954cbe28c1f202573d6fb on linxlad:master into 551482eadb8b5d9cacda46a8afa8108ae9e08cdb on craue:master.

coveralls avatar Jun 03 '16 12:06 coveralls

Coverage Status

Coverage decreased (-2.3%) to 97.407% when pulling 066357d6cf7ae7856545289702c2d1d287a36ed2 on linxlad:master into 551482eadb8b5d9cacda46a8afa8108ae9e08cdb on craue:master.

coveralls avatar Jun 03 '16 13:06 coveralls

Coverage Status

Coverage decreased (-2.3%) to 97.407% when pulling 066357d6cf7ae7856545289702c2d1d287a36ed2 on linxlad:master into 551482eadb8b5d9cacda46a8afa8108ae9e08cdb on craue:master.

coveralls avatar Jun 03 '16 13:06 coveralls

Coverage Status

Coverage decreased (-2.3%) to 97.407% when pulling 066357d6cf7ae7856545289702c2d1d287a36ed2 on linxlad:master into 551482eadb8b5d9cacda46a8afa8108ae9e08cdb on craue:master.

coveralls avatar Jun 03 '16 13:06 coveralls

Coverage Status

Coverage decreased (-2.3%) to 97.407% when pulling 066357d6cf7ae7856545289702c2d1d287a36ed2 on linxlad:master into 551482eadb8b5d9cacda46a8afa8108ae9e08cdb on craue:master.

coveralls avatar Jun 03 '16 13:06 coveralls

@craue Does this look ok? :)

linxlad avatar Jun 06 '16 09:06 linxlad

@craue Been nearly 6 months now. Is this git abandoned?

linxlad avatar Dec 06 '16 10:12 linxlad

Is this git abandoned?

@linxlad, as you can see from the commit history, it is not. 😏

I'm still trying to implement transitions (#67), which would be a more flexible approach than this one. Furthermore, tests are completely missing here.

craue avatar Dec 09 '16 12:12 craue

Please, can we have this pull request? It is a very useful feature I also want.

TerjeBr avatar Dec 16 '16 10:12 TerjeBr

@craue This one fits with what you currently code and I am unsure of how #67 would solve the persistence of data on stepping back?

linxlad avatar Mar 07 '17 13:03 linxlad

Still, there are no tests covering this functionality, so I cannot merge it yet.

craue avatar Aug 07 '17 14:08 craue