cargo-release icon indicating copy to clipboard operation
cargo-release copied to clipboard

Silently does nothing if the version desired is the same as the current version

Open passcod opened this issue 3 years ago • 0 comments

I was trying to release a new package without publishing. I set its version to 1.0.0 in the Cargo.toml, then called cargo release 1.0.0. That then proceeded to confirm I wanted to do that as normal, then did absolutely nothing.

Digging into it, this bit: https://github.com/crate-ci/cargo-release/blob/master/src/version.rs#L38-L42 means that pkg.version is None, and this check: https://github.com/crate-ci/cargo-release/blob/master/src/release.rs#L211 among others, silently bypasses most actual work until the tool just finishes with exit code 0, having done nothing.

That was a bit of a frustrating experience.

passcod avatar Jun 16 '22 08:06 passcod