splittable icon indicating copy to clipboard operation
splittable copied to clipboard

allow splittable user to use additional plugins in the deps finding pipeline

Open erwinmombay opened this issue 8 years ago • 2 comments

this is needed as there are some constructs that the jison library generates that blows up with "use strict" directive. I need to be able to pass "transform-remove-strict-mode" plugin

erwinmombay avatar Sep 25 '17 11:09 erwinmombay

Its fine. We really just discover deps here. Should be less strict than closure compiler.

On Mon, Sep 25, 2017 at 10:29 AM, erwin mombay [email protected] wrote:

@erwinmombay commented on this pull request.

In splittable.js https://github.com/cramforce/splittable/pull/51#discussion_r140843234:

@@ -238,9 +238,10 @@ exports.getGraph = function(entryModules, config) { // directly and which we don't want to apply during deps finding. transform(babel, { babelrc: false,

  • plugins: [
  • plugins: Array.isArray(config.babel.plugins) ? config.babel.plugins.concat([

ideally it shouldn't since the "use strict" directive is desirable after all (correct me if im wrong), its just unfortunate that jison uses a lot of labels and jumps

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cramforce/splittable/pull/51#discussion_r140843234, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFeT2w7BtBu7aUZmvflag7PXof-CLYCks5sl-MQgaJpZM4PikFV .

cramforce avatar Sep 25 '17 17:09 cramforce

@cramforce ah right. that makes sense. ill make the changes and move the export babel plugin back into the splittable repo

erwinmombay avatar Sep 25 '17 21:09 erwinmombay