react-native-quick-base64 icon indicating copy to clipboard operation
react-native-quick-base64 copied to clipboard

New Architecture Support

Open nickvgn opened this issue 1 year ago • 3 comments

Any plans on supporting the new architecture? It is enabled by default in the next version of React Native 0.74. There is a discussion taking place here among other library authors migrating their library as well

nickvgn avatar Apr 10 '24 07:04 nickvgn

Hey! I've managed to move completely from this library in favor of rn-quick-crypto. At least it supports new architecture. I use btoa without any imports and it works perfectly for me

btw that's what i've found in rn-quick-crypto library https://github.com/margelo/react-native-quick-crypto/issues/18#issuecomment-2065394175

iliapnmrv avatar Sep 30 '24 15:09 iliapnmrv

Hey! I've managed to move completely from this library in favor of rn-quick-crypto. At least it supports new architecture. I use btoa without any imports and it works perfectly for me

btw that's what i've found in rn-quick-crypto library margelo/react-native-quick-crypto#18 (comment)

@iliapnmrv Nice, thanks for sharing that! am I right in understanding that the latest version of rn-quick-crypto is much faster at base64 encoding and decoding than this lib (react-native-quick-base64)?

TowhidKashem avatar Oct 03 '24 23:10 TowhidKashem

@TowhidKashem as I understand yes, it is much faster

iliapnmrv avatar Oct 04 '24 06:10 iliapnmrv

Hey! I've managed to move completely from this library in favor of rn-quick-crypto. At least it supports new architecture. I use btoa without any imports and it works perfectly for me btw that's what i've found in rn-quick-crypto library margelo/react-native-quick-crypto#18 (comment)

@iliapnmrv Nice, thanks for sharing that! am I right in understanding that the latest version of rn-quick-crypto is much faster at base64 encoding and decoding than this lib (react-native-quick-base64)?

I don't think rn quick crypto implement the Buffer part internally, I see on https://github.com/margelo/react-native-quick-crypto/blob/252758b96bef87ed5ae9783b137b10f56d64eeb4/packages/react-native-quick-crypto/src/index.ts#L2 it was depends on rn quick base64 though

byrizki avatar Oct 10 '24 05:10 byrizki

@nickvgn @iliapnmrv the lib supports the new architecture. if you look into margelo's source it's dependent on @craftzdog/react-native-buffer which uses react-native-quick-base64 under the hood

gabimoncha avatar Jan 28 '25 15:01 gabimoncha

This is a JSI-based library that doesn't use the old bridge. I don't know what to do with supporting the new arch.

craftzdog avatar Jan 28 '25 23:01 craftzdog

This is a JSI-based library that doesn't use the old bridge. I don't know what to do with supporting the new arch.

you don't have to do anything. you are already supporting it :)

gabimoncha avatar Jan 29 '25 17:01 gabimoncha