commerce icon indicating copy to clipboard operation
commerce copied to clipboard

[5.x][4.x]: Improve setting amount when adding a donation line item in the CP

Open icreatestuff opened this issue 1 year ago • 3 comments

What happened?

Description

When adding a donation line item to an order from the control panel there is no option to set the donation amount, which then triggers an error preventing the order from being able to update on save.

Curiously you can set the quantity of donation line items to add, which presumably should only ever be a maximum of 1.

Steps to reproduce

  1. Enable donations
  2. Create an order
  3. Add the donation line item
  4. See the error about no Donation Amount set

Expected behavior

Adding a donation line item should allow setting the amount

Actual behavior

No amount field is visible when adding the donation line item, causing the amount to be set to 0 and therefore causing an error

Craft CMS version

Pro 4.13.0

Craft Commerce version

4.7.0

PHP version

8.1.29

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

icreatestuff avatar Nov 21 '24 14:11 icreatestuff

Hi @icreatestuff

Thank you for your feedback.

It is possible to create an amount on a donation line item. It follows the same convention, technically, as it does when creating a donation from the front end. This is in the fact that it uses the donationAmount key in the line item options.

The video below shows how this is possible:

https://github.com/user-attachments/assets/8f436553-523a-4da0-ada4-75d74f661932

We understand that this is not the most ideal way of managing this process. I will update this issue to be a feature request so this is something that we can look into improving in a future release of Commerce.

Thanks!

nfourtythree avatar Nov 22 '24 08:11 nfourtythree

Thanks @nfourtythree for the explanation and demo video. As a dev, having some understanding of the underlying architecture for how Commerce is working, I could just about work with that. For clients, this is too complex a process. Thanks for making this a feature request.

icreatestuff avatar Nov 25 '24 15:11 icreatestuff