mir_eval icon indicating copy to clipboard operation
mir_eval copied to clipboard

Chroma transcription metrics

Open chf2117 opened this issue 9 years ago • 11 comments

Implements and tests #197

chf2117 avatar Jan 09 '17 15:01 chf2117

Thanks Caleb. Apart from PEP8 stuff, you'll also need to add separate evaluation for chroma metrics to mir_eval.transcription.evaluate, e.g. forcing the value of chroma in the kwargs dict to be True, then False, so that both are evaluated (right @justinsalamon)?

Do we have any implementations to test this against? It's a small enough change that I am ok with not testing it against something existing, though we should be very certain in its correctness then :)

craffel avatar Jan 09 '17 16:01 craffel

Thanks Caleb. Apart from PEP8 stuff, you'll also need to add separate evaluation for chroma metrics to mir_eval.transcription.evaluate, e.g. forcing the value of chroma in the kwargs dict to be True, then False, so that both are evaluated (right @justinsalamon)?

yes

Do we have any implementations to test this against?

yes, see here.

justinsalamon avatar Jan 09 '17 16:01 justinsalamon

yes, see here.

The music-ir link is dead for me. Do you know of any others?

chf2117 avatar Jan 09 '17 17:01 chf2117

The music-ir link is dead for me. Do you know of any others?

The MIREX website is temporarily down, my understanding is that they're working on it. I'll check if I have the result files stored locally somewhere, otherwise we'll have to wait till it's back up.

justinsalamon avatar Jan 09 '17 18:01 justinsalamon

Now that the MIREX website is back up, can we move forward on this?

craffel avatar Feb 27 '17 17:02 craffel

Yes, I'll try to wrap it up in the next couple days

chf2117 avatar Feb 28 '17 14:02 chf2117

I'm a bit confused about comparing to MIREX results. The existing output*.json files don't match the differences from this comment, so I'm not sure what to look for when comparing the results.

chf2117 avatar Jun 11 '17 15:06 chf2117

I'm a bit confused about comparing to MIREX results. The existing output*.json files don't match the differences from this comment, so I'm not sure what to look for when comparing the results.

@justinsalamon can you provide some guidance here?

craffel avatar Jul 24 '17 00:07 craffel

Bumping this one, since it seems like everyone disappeared after summer?

bmcfee avatar Jan 29 '18 16:01 bmcfee

Is it still planned to integrate this functionality and does anybody know which points are still open?

TGabor avatar Apr 21 '20 15:04 TGabor

This needs to be picked up again. I don't think anyone is planning on doing so.

craffel avatar Apr 21 '20 21:04 craffel