cpp-linter-action icon indicating copy to clipboard operation
cpp-linter-action copied to clipboard

python venv cache support

Open h0tw1r3 opened this issue 1 year ago • 3 comments

hashFiles currently doesn't support globs outside of the GITHUB_WORKSPACE. This works around the limitation.

h0tw1r3 avatar Apr 22 '24 17:04 h0tw1r3

FYI, I think the CI failed on MacOS runners because of segfaults. This isn't anything to do with the changes here, rather we should look into this separately.

2bndy5 avatar Apr 22 '24 18:04 2bndy5

I also think there should be some logic added to detect presence of a cached venv before creating a venv. https://github.com/cpp-linter/cpp-linter-action/blob/a3ed7553c695735e6d1af356a0c0211a77d42c7b/action.yml#L241 https://github.com/cpp-linter/cpp-linter-action/blob/a3ed7553c695735e6d1af356a0c0211a77d42c7b/action.yml#L277 The above lines might fail if the venv folder already exists.

2bndy5 avatar Apr 22 '24 21:04 2bndy5

I guess we should also cache pip's global cache as well if this new option is enabled.

2bndy5 avatar Apr 22 '24 21:04 2bndy5