cpburnz
Faster start of RE
Sorry, I did not save it
On Tue, Sep 6, 2022, 3:58 AM Ofek Lev @.***> wrote:
Can you show benchmarks here?
— Reply to this email directly, view it on GitHub https://github.com/cpburnz/python-pathspec/pull/59#issuecomment-1237555136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARGSBY6EZYPTMMP35OPC4LV42JJ3ANCNFSM573P7LQA . You are receiving this because you authored the thread.Message ID: @.***>
Well it's up to a reviewer to make any tests they want or need
On Tue, Sep 6, 2022, 7:17 AM Ofek Lev @.***> wrote:
Then how can one determine whether or not to accept this PR?
— Reply to this email directly, view it on GitHub https://github.com/cpburnz/python-pathspec/pull/59#issuecomment-1237640433, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARGSB3U2K4IWNXK7QLAPO3V43AVNANCNFSM573P7LQA . You are receiving this because you authored the thread.Message ID: @.***>
Hi @excitoon, do you have a benchmark comparing the change to the original?
Yes, I had. I ran it on ClickHouse source code with all submodules recursively synced. It showed about 5% improvement.
But you have to reproduce it yourself to be 100% sure
On Thu, Sep 8, 2022, 5:27 AM Caleb P. Burns @.***> wrote:
Hi @excitoon https://github.com/excitoon, do you have a benchmark comparing the change to the original?
— Reply to this email directly, view it on GitHub https://github.com/cpburnz/python-pathspec/pull/59#issuecomment-1240142624, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARGSB4CR3ZM3M3NEHSCXILV5FFJXANCNFSM573P7LQA . You are receiving this because you were mentioned.Message ID: @.***>