github-action icon indicating copy to clipboard operation
github-action copied to clipboard

Difference in relevant lines calculation between python versions 3.7 and greater

Open jtroussard opened this issue 4 years ago • 1 comments

Description

Our pipeline runs coverallsapp action in parallel with several different versions of python. Noticed that after making a non-functional change to a file, (removed comment) our coveralls check was failing the build for a -0.0% decrease.

Difference Between Versions

Search results in a small difference the relevant lines are calculated between python versions:

3.7 37

3.8 38

The difference between the to are the method declaration lines. 3.6 and 3.7 seem to leave it out, while 3.8 and beyond include the line as "relevant". This is the only significant difference I can find between the passing coveralls checks (3.6, 3.7) and the failing checks, (3.8, 3.9)

Questions

  • Can anyone shed any light on this issue?
  • Is there a workaround besides increasing the failure threshold?
  • Is this a bug?
  • Am I misdiagnosing my coverage failures?

jtroussard avatar Jan 02 '22 20:01 jtroussard

Wanted to add a screenshot of the coveralls github action results to further illustrate

Screen Shot 2022-01-04 at 2 49 37 PM

jtroussard avatar Jan 04 '22 19:01 jtroussard