github-action icon indicating copy to clipboard operation
github-action copied to clipboard

[Doc Bug] What causes the check to fail?

Open zfields opened this issue 4 years ago • 2 comments

I apologize if I missed this, and I'm sure it will become immediately obvious once I begin using it, but what exactly makes the "Coveralls Check" fail?

  1. Does it fail anytime new coverage is less than existing coverage?
  2. Does it have any other criteria?
  3. Can the criteria be modified?

It may be worth mentioning, if (1) is true, that is exactly what I'm looking for.

I am trying to make a business case to migrate us onto Coveralls, and I don't know what causes the GitHub check to fail by simply reading your documentation.

A simple bulleted of "the rules" is all I need, and I think it would also make a great addition to your README.

zfields avatar Nov 04 '21 12:11 zfields

Does it fail anytime new coverage is less than existing coverage?

I think this is true too

There should be an option to disable this or a coverage threshold

nopeless avatar Dec 17 '21 06:12 nopeless

@zfields After some research I found out that you can change the repo settings

https://github.com/lemurheavy/coveralls-public/issues/565#issuecomment-120924694

A little note to self is that

You should be on the repo not the build result page (the page you get when clicking the run badge)

Just click your repo on the repos tab and there should be settings on top or left

nopeless avatar Dec 17 '21 06:12 nopeless