hermes icon indicating copy to clipboard operation
hermes copied to clipboard

Gas ring model: sun position

Open carmeloevoli opened this issue 4 years ago • 1 comments

The gas ring model cannot be used with an observer position different than [8.5,0,0]. An exception should be raised if not.

carmeloevoli avatar Mar 26 '21 07:03 carmeloevoli

This can be solved by introducing checks in the integrators' constructors which accepts the gas ring model. The ring model would provide its requirements (like the observer position) and the integrator would use them to check if everything is O.K. with other settings. But I would leave this change after the release of 1.0 as it is more like a new feature.

adundovi avatar Apr 07 '21 07:04 adundovi