agnpy icon indicating copy to clipboard operation
agnpy copied to clipboard

Start to implement photo-meson interactions

Open cosimoNigro opened this issue 2 years ago • 4 comments

@IlariaViale, @dimaniad6, let us use this branch to work on the implementation of the photomeson interactions. We are following the analytical parametrisation of Kelner Aharonian 2008 (https://arxiv.org/abs/0803.0688).

cosimoNigro avatar Jul 05 '23 14:07 cosimoNigro

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (c268fa8) 97.02% compared to head (256fe4a) 95.39%.

:exclamation: Current head 256fe4a differs from pull request most recent head a11cec2. Consider uploading reports for the commit a11cec2 to get more accurate results

Files Patch % Lines
agnpy/photo_meson/kernels.py 25.31% 59 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   97.02%   95.39%   -1.63%     
==========================================
  Files          43       45       +2     
  Lines        3394     3474      +80     
==========================================
+ Hits         3293     3314      +21     
- Misses        101      160      +59     
Flag Coverage Δ
unittests 95.39% <26.25%> (-1.63%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 05 '23 14:07 codecov[bot]

Hello @dimaniad6, @IlariaViale, do you think you will have some time in the next days to work on this?

cosimoNigro avatar Sep 01 '23 09:09 cosimoNigro

Thanks for the updates @dimaniad6, @IlariaViale, I did not mean to rush you.

By the way, when you reply to GitHub notifications via mail your reply is also posted on GitHub 😄, I am removing your replies since they contain personal informations.

cosimoNigro avatar Sep 04 '23 15:09 cosimoNigro

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB