corona icon indicating copy to clipboard operation
corona copied to clipboard

Error Checking for build.settings

Open tlyndon opened this issue 4 years ago • 5 comments

We need Solar2D to have some built-in error checking for build.settings. We had an issue that took some time to solve, and we spent hours tracking down an issue a simple error checker could have alerted us to.

tlyndon avatar Aug 10 '21 11:08 tlyndon

You'll need to be a bit more specific. As far as I'm aware, Solar2D does have "some built-in error checking for build.settings."

XeduR avatar Aug 10 '21 12:08 XeduR

sure, it needs to check that each section is properly closed, checking pairs of [ ] { } and anything else Vlad can think of

tlyndon avatar Aug 10 '21 13:08 tlyndon

Vlad asked me to write this here, as he definitely sees a need for it

tlyndon avatar Aug 10 '21 13:08 tlyndon

I just tested building for Android and seems that if you have a missing bracket then you'll get hit by:

16:01:50.272  Picked up JAVA_TOOL_OPTIONS: -Duser.language=en
16:01:50.272  ERROR: Syntax error
16:01:50.272  C:\.....\test\build.settings:58: '}' expected (to close '{' at line 7) near '<eof>'
16:02:03.641  ERROR: Syntax error
16:02:03.641  C:\.....\test\build.settings:55: '}' expected (to close '{' at line 52) near 'android'

XeduR avatar Aug 10 '21 13:08 XeduR

There are issues with checking validity of build.settings, for example some builds won't fail producing weird results

Shchvova avatar Aug 10 '21 16:08 Shchvova