dicomParser icon indicating copy to clipboard operation
dicomParser copied to clipboard

Npm package 1.8 is not working.

Open jpambrun opened this issue 7 years ago • 1 comments

The node package is broken. I get :

ReferenceError: window is not defined

(function webpackUniversalModuleDefinition(root, factory) {
	if(typeof exports === 'object' && typeof module === 'object')
		module.exports = factory();
	else if(typeof define === 'function' && define.amd)
		define("dicom-parser", [], factory);
	else if(typeof exports === 'object')
		exports["dicom-parser"] = factory();
	else
		root["dicomParser"] = factory();
})(window, function() {   // <==== HERE
return /******/ (function(modules) { // webpackBootstrap
/******/ 	// The module cache
/******/ 	var installedModules = {};

I suppose this is probably due to the change to webpack 4? At least one node test case should probably be included..

jpambrun avatar Apr 28 '18 00:04 jpambrun

Ah damn. Thanks for letting us know!

swederik avatar May 02 '18 13:05 swederik

Fixed in #87

yagni avatar Aug 22 '23 21:08 yagni