dicomParser icon indicating copy to clipboard operation
dicomParser copied to clipboard

Don't include tag if not needed

Open jssuttles opened this issue 9 years ago • 2 comments

https://github.com/chafey/dicomParser/issues/43 { untilTag: { tag: '', include: false } } untilTag option now takes object like above or string like before

jssuttles avatar Jul 16 '16 21:07 jssuttles

Is c55297f necessary? You can already tell if a byteArrayParser is big or little endian by comparing it to the dicomParser.bigEndianByteArrayParser and dicomParser.littleEndianByteArrayParser objects directly.

yagni avatar Aug 02 '16 14:08 yagni

Probably didn't need to push that to this pull request, however, if the dicomWriter that I wrote is to understand whether data is to be handled with little endian or big endian without having to look at the data itself, then it's a really nice helper. The dicomWriter, then, doesn't need to require the dicomParser, so that it can compare the parsers.

jssuttles avatar Aug 02 '16 23:08 jssuttles