cornerstoneTools icon indicating copy to clipboard operation
cornerstoneTools copied to clipboard

Ultrasound Region Measurements

Open jdnarvaez opened this issue 3 years ago • 1 comments

Addresses https://github.com/cornerstonejs/cornerstoneTools/issues/210

  • Please check if the PR fulfills these requirements
  • [X] The commit message follows our guidelines
  • [X] Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)

This changes how the row pixel spacing, column pixel spacing, and measurement suffix are determined for a Length measurement. If an image contains a non zero length value for the Sequence of Ultrasound Regions (0018,6011) tag, then these regions are searched to find a single region that contains both measurement points (sorted by largest overall area first). If the measurement spans multiple regions, then the spacing information is only used if the regions contain the same information. If no region is found, the measurement is assumed to be that of 'pixels'. If an image does not contain a non-zero length value for this tag, then the original getPixelSpacing method is called as before.

jdnarvaez avatar Feb 14 '22 15:02 jdnarvaez

Codecov Report

Merging #1466 (382a022) into master (95c3b7c) will decrease coverage by 0.10%. The diff coverage is 11.71%.

@@            Coverage Diff             @@
##           master    #1466      +/-   ##
==========================================
- Coverage   20.16%   20.06%   -0.11%     
==========================================
  Files         287      288       +1     
  Lines       10102    10223     +121     
  Branches     2060     2097      +37     
==========================================
+ Hits         2037     2051      +14     
- Misses       6852     6951      +99     
- Partials     1213     1221       +8     
Impacted Files Coverage Δ
.../tools/referenceLines/renderActiveReferenceLine.js 0.00% <0.00%> (ø)
src/store/modules/ultrasound/region.js 4.39% <4.39%> (ø)
src/tools/annotation/LengthTool.js 36.60% <30.55%> (-0.75%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Feb 14 '22 15:02 codecov[bot]