PR for fixing rotate tool and crosshairs tool
- Please check if the PR fulfills these requirements
- [x] The commit message follows our guidelines
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been added / updated (for bug fixes / features)
- What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
- Fix rotate tool error on mobile device ( #1112 , #1114 )
- Fix crosshairs tool not working because the synchronizationContext is alway undefined ( the example page is not working)
-
What is the current behavior? (You can also link to an open issue here)
-
What is the new behavior (if this is a feature change)?
-
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) Yes, crosshairs tool now supports the mouse click and the touch start event
-
Other information:
Codecov Report
:x: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 18.95%. Comparing base (0868812) to head (fa3bf29).
:warning: Report is 130 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1134 +/- ##
==========================================
+ Coverage 18.94% 18.95% +0.01%
==========================================
Files 286 286
Lines 8647 8650 +3
Branches 1476 1478 +2
==========================================
+ Hits 1638 1640 +2
+ Misses 5803 5802 -1
- Partials 1206 1208 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Oh, sorry. This change for my local test only.
On Wed, Dec 4, 2019 at 16:55 Danny Brown [email protected] wrote:
@dannyrb commented on this pull request.
In package.json https://github.com/cornerstonejs/cornerstoneTools/pull/1134#discussion_r353644351 :
@@ -1,6 +1,6 @@ { "name": "cornerstone-tools",
- "version": "4.0.1",
- "version": "4.7.1-m",
-m?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cornerstonejs/cornerstoneTools/pull/1134?email_source=notifications&email_token=AEX36LIVKV53B5MGCFK7LT3QW55AHA5CNFSM4JQK5ZLKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCN4V3BY#pullrequestreview-326720903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEX36LKAS4V6SAECOPHS3KLQW55AHANCNFSM4JQK5ZLA .
@dannyrb Thanks for review this PR, i have reverted the package version and remove useless comment
The dist is still checked in?
the dist was removed
Hi, how about this PR can be reviewed ?
The issue for this is that the dist is still checked in:

The issue for this is that the dist is still checked in:
the dist folder have been removed
Did this PR had been reviewed ?
waiting for reviewed