cornerstoneMath icon indicating copy to clipboard operation
cornerstoneMath copied to clipboard

Reference lines do not show using v0.1.9 for MRI-3T

Open septembersoul opened this issue 4 years ago • 3 comments

Reference lines do not show using v0.1.9 for MRI-3T studies (axial/sagittal series). v0.1.8 works fine.

I'm using

  • Cornerstone v2.3.0
  • Tools v5.1.4
  • DicomParser v1.8.7

septembersoul avatar May 12 '21 14:05 septembersoul

I'm having the same issue, reverting to v0.1.8 also fixes it for me.

  • cornerstone-core v2.6.0
  • cornerstone-tools v6.0.2
  • cornerstone-wado-image-loader v4.0.4

https://github.com/cornerstonejs/cornerstoneTools/blob/e81f1b6c5e2fec31d5641f7f95a8f9925e92eb1e/src/util/pointProjector.js#L119-L131

This function always returns 0 intersections

jpinxten avatar Oct 14 '21 10:10 jpinxten

Maybe broken by @ladeirarodolfo in this commit? https://github.com/cornerstonejs/cornerstoneMath/commit/825a7b5551ed1bffa75ba84e380ddc7b365e7c3d

swederik avatar Oct 14 '21 13:10 swederik

In my case issue appears here https://github.com/cornerstonejs/cornerstoneMath/blob/eb61ec1eda63623c766879e1b934776237001c93/src/Line3.js#L149

I changed it to if (s >= 1.1 || isNaN(s)) and reference lines became visible. Value of s variable was about 1.0938...

septembersoul avatar Oct 15 '21 12:10 septembersoul