react-native-video-player icon indicating copy to clipboard operation
react-native-video-player copied to clipboard
verified publisher icon cornedor

Add volume control && volume bar && duration display

Open AaronTYZ opened this issue 7 years ago • 4 comments

Volume control new supported. Volume bar display when tap. Video duration display along with control bar. Good Interative.

Before merged, u can ref to here

AaronTYZ avatar Mar 19 '18 11:03 AaronTYZ

I'm still interested in this PR. 1 Issue I have with it is how you automatically mute all video's, Why would you remove the "muted" prop to have no effect? Also adding a prop to show/hide the duration text would be preferred.

I can totally understand that after 11 months you might not have interest in this PR, but I hope at least the owner @cornedor can look into this PR and make it happen.

pieter888 avatar Feb 22 '19 13:02 pieter888

Ah :) Didn't realize this was 11 months old. Do like the capability that it could add and thank you for the work!

@cornedor did you consider this addition?

petrogad avatar Mar 28 '19 22:03 petrogad

In your formatTime method, i think there should be sec = '0' + sec.toString(); instead of minute = '0' + sec.toString();,

suhasgaji19 avatar Jul 22 '19 06:07 suhasgaji19