node-linux icon indicating copy to clipboard operation
node-linux copied to clipboard
verified publisher icon coreybutler

Add ability to pass arguments and change the executable path

Open athieriot opened this issue 12 years ago • 4 comments

Hi,

I have added two new arguments: execPath and scriptArgs.

  • execPath allows to change the path of Node.js. Convenient to run Coffeescript scripts
  • scriptArgs can be use to pass arguments to a Node.js script

You will also find a change that prevent the creation of <script>_error.log and <script>-error.log files

Please tell me if you want two different Pull Requests. Or anything you want me to change really :)

Thank you for this excellent project

Aurélien

athieriot avatar Jul 20 '13 13:07 athieriot

+1 for this

mikaelkaron avatar Jul 23 '13 10:07 mikaelkaron

Could you split this into 2 PR's? I will likely include both, but I want to review the other two libraries as well regarding execPath and scriptArgs. My goal is consistency (or as much as possible) between the 3 libraries. There are some similar/related requests on node-mac/windows. However; that shouldn't stop me from fixing the error file path.

coreybutler avatar Jul 23 '13 21:07 coreybutler

No problem. First thing in the morning.

Feel free to ask if you want me to do the same commit on node-mac and node-windows when you are happy with it

athieriot avatar Jul 23 '13 21:07 athieriot

In fact, it was easy enough to do it immediately: https://github.com/coreybutler/node-linux/pull/6

athieriot avatar Jul 23 '13 21:07 athieriot