modsecurity-docker icon indicating copy to clipboard operation
modsecurity-docker copied to clipboard

Added optional MODSEC_DISABLE_BACKEND_COMPRESSION env variable

Open karelorigin opened this issue 3 years ago • 2 comments

The ModSecurity SecDisableBackendCompression could not be configured in this docker image. This PR adds that option.

karelorigin avatar May 19 '22 11:05 karelorigin

Maybe we can add some shell scripting to only generate the variable if running on apache. This error doesn't look nice, and might confuse users:

nginx-nightly            | nginx: [emerg] "modsecurity_rules_file" directive Rules error. File: /etc/modsecurity.d/modsecurity.conf. Line: 224. Column: 19. SecDisableBackendCompression is not supported.  in /etc/nginx/conf.d/modsecurity.conf:2

If we can live with that, then no problems

fzipi avatar Jun 18 '22 13:06 fzipi

Good point. I agree that we should remove it from httpd.

theseion avatar Jun 18 '22 19:06 theseion

I've tried to recreate the issue you had with nginx and the variable but I can't. I believe it was already solved with additional RUN instruction that comments the directive for v3.

I've rebased onto develop, so that builds should run again.

theseion avatar Sep 24 '22 08:09 theseion