etcd-operator icon indicating copy to clipboard operation
etcd-operator copied to clipboard
verified publisher icon coreos

backup operator: fixed incorrect backup file naming convention.

Open kapouille opened this issue 6 years ago • 5 comments

When limiting the number of backups, if the revision would move to needing another digit, the logic would never select a new entry as _ is > to 9 in ascii terms.

Note that this is backwards incompatible as now files receive a correct padding and old revisions will still be incorrectly handled.

kapouille avatar Apr 05 '19 15:04 kapouille

Can one of the admins verify this patch?

etcd-bot avatar Apr 05 '19 15:04 etcd-bot

Can one of the admins verify this patch?

etcd-bot avatar Apr 05 '19 15:04 etcd-bot

Can one of the admins verify this patch?

etcd-bot avatar Apr 05 '19 15:04 etcd-bot

@etcd-bot ok to test

hexfusion avatar Apr 06 '19 12:04 hexfusion

@kapouille it looks like we missed this line in the tests

https://github.com/coreos/etcd-operator/blob/86211e9f3bc32cd97187c7ee9beb32be60264fed/test/e2e/e2eslow/backup_restore_test.go#L55

mikenorgate avatar Apr 07 '19 14:04 mikenorgate