coreos-assembler Add CheckConsoleText(WIP)

Ref: https://github.com/coreos/coreos-assembler/issues/3788

Sep 02 '24 16:09 c4rt0

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

Sep 02 '24 16:09 openshift-ci[bot]

As I work on this issue I noticed that awaitCompletion() does not specify what console is. In this case (if my understanding is not flawed) Go automatically assigns it false hence forces the code to execute every time. NewBaseQemuBuilder() assigns it through builder.InheritConsole ... I wonder if that's a bug in case of awaitCompletion?

Sep 24 '24 17:09 c4rt0

Running the tests with --console should set the value to true

Sep 24 '24 18:09 jbtrystram

Running the tests with --console should set the value to true

Now, that makes sense :) Merci!

Sep 24 '24 21:09 c4rt0

Just a quick update: Some things in this PR are most likely not-recommend.

hardcoding the console.txt consoleFilePath := filepath.Join(outdir, "console.txt") Especially, since platform.Machine already contains ConsoleOutput Moving to consoleFilePath := m.ConsoleOutput() instead.
passing m platform.Machine into all of the testiso tests (don't know how I came up with that idea) ie: func testLiveFIPS(ctx context.Context, outdir string, m platform.Machine)

Will work on the above and push once completed.

Sep 30 '24 13:09 c4rt0