helm icon indicating copy to clipboard operation
helm copied to clipboard

Please support configuring environment variables for the cluster-proportional-autoscaler container

Open stevo-f3 opened this issue 2 years ago • 1 comments

E.g. to enable configuring Go runtime with GOMAXPROCS and GOMEMLIMITS environment variables.

Optionally, consider setting GOMAXPROCS and GOMEMLIMITS env vars automatically relative to the configured resources (CPU requests, and memory limits, respectively), when resources are configured.

With current default resource configuration (20m CPU requests and limits) and no GOMAXPROCS configured, there's lots of CPU throttling. Upstream chart doesn't set default resource configuration, so partially issue could be solved with https://github.com/coredns/helm/issues/103 - at least it would move upstream.

stevo-f3 avatar Nov 16 '23 12:11 stevo-f3

I understand your point, but at this point I wouldn't want to make any changes until we get #103 done

hagaibarel avatar Dec 07 '23 11:12 hagaibarel