corbado-nodejs icon indicating copy to clipboard operation
corbado-nodejs copied to clipboard

Extend SDK to include FrontendAPI calls

Open sam-corbado opened this issue 2 years ago • 1 comments

Description

We extend the Node SDK with calls that are useful to our Firebase service. This then releases the Firebase service from directly interacting with the API.

Fixes #20.

Type of change

Please delete options that are not relevant.

  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Test A
  • [ ] Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

sam-corbado avatar Jan 29 '24 09:01 sam-corbado

Codecov Report

Attention: Patch coverage is 24.44444% with 68 lines in your changes missing coverage. Please review.

Project coverage is 21.64%. Comparing base (79321c7) to head (b13211e). Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/generated/frontendApi/common.ts 18.96% 46 Missing and 1 partial :warning:
src/generated/frontendApi/configuration.ts 7.69% 12 Missing :warning:
src/generated/frontendApi/base.ts 40.00% 6 Missing and 3 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   26.26%   21.64%   -4.62%     
==========================================
  Files          25       29       +4     
  Lines        3233     4125     +892     
  Branches      618      803     +185     
==========================================
+ Hits          849      893      +44     
- Misses       2192     3006     +814     
- Partials      192      226      +34     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 29 '24 09:01 codecov[bot]