react-player icon indicating copy to clipboard operation
react-player copied to clipboard

Twitch controls not able to hide when controls set to false

Open markchen555 opened this issue 4 years ago • 3 comments

Current Behavior

I want to hide controls from the Twitch stream channel when I set controls props to false but the controls query still shows true.

Expected Behavior

The controls should be hidden when I set the controls props to false.

Steps to Reproduce

  1. set controls props to false
  2. inspect the iframe and you will see the controls query is still true.
  3. Twitch stream control still shows

Environment

  • URL attempting to play: https://cookpete.com/react-player/
  • Browser: Google Chrome Version 92.0.4515.13
  • Operating system: Windows 10

Other Information

Capture

markchen555 avatar Sep 03 '21 22:09 markchen555

Mine works fine , when I click the "Controls" checkbox the iframe source shows appropriately and the player also displays appropriately.

AlvesJorge avatar Sep 04 '21 09:09 AlvesJorge

Mine works fine , when I click the "Controls" checkbox the iframe source shows appropriately and the player also displays appropriately.

If you use the Twitch Test A which is only a video then the Controls check box works fine. If you use the Test C and Custom URL with channel format, ex: twitch.tv/{channel name}, it will not work.

in the source code: image

If the URL is "twitch.tv/{channel name}" which only contains channel name, it will set the Controls props always to true.

markchen555 avatar Sep 04 '21 14:09 markchen555

someone has the same issue as me

https://github.com/cookpete/react-player/issues/1236

markchen555 avatar Sep 06 '21 00:09 markchen555