php-commitizen icon indicating copy to clipboard operation
php-commitizen copied to clipboard

fix(add all): Change dot for dash A on git add

Open AdGARAY opened this issue 5 years ago • 4 comments

This change must prevent that someone create a new commit inside a directory, the git add . only adds the current directory, git add -A adds all the files in the repository

AdGARAY avatar Oct 12 '20 17:10 AdGARAY

Sorry for the embarrassing-late review, did you have any issue with this? If so I'll rather add a new flag rather than introducing a BC to the package, what do you think?

damianopetrungaro avatar Dec 15 '20 22:12 damianopetrungaro

That sounds good, how could you name it?, the only thing that I say is that --all and -a we wait to stage all and if we run git add. only adds the directory so we spect to have all the files but only the actual dir is added

AdGARAY avatar Dec 18 '20 05:12 AdGARAY

what do you think about --all-repo and -ar? 🤔

damianopetrungaro avatar Dec 18 '20 11:12 damianopetrungaro

That looks good 💯

AdGARAY avatar Dec 18 '20 17:12 AdGARAY