Luke Deen Taylor

Results 156 comments of Luke Deen Taylor

Can’t leva release a new major version requiring React 18 (and using the new `createRoot` API), and leave the previous major version stay for React 17 compatibility? That’s my understanding...

I got the new location building, but this looks like a whole new coveralls account. How can I transfer the history from the old page to the new one?

I’ve found a pretty good solution in the following: ```js router.beforePopState((state) => { state.options.scroll = false; return true; }); ```

Sure, @Timer: I created a [repository showing the behavior](https://github.com/controversial/20951-repro) by the following steps: 1. created a new app with `create-next-app` 2. I duplicated the example page to create two pages,...

Here's the alternate test case you described. I: 1. scroll down on page A 2. move to page B 3. press “back” to page A As you can see, the...

Adding `'use client'` still breaks styling for me on Next.js 13.0.1

Never mind, it was my mistake @shuding 😅 Of course, I realized as soon as I went to start creating a reproduction. Thanks for being on top of it! ❤️

I’ve tried a few times to make tests pass but it seems like there are some tests (with the bundle size snapshots, specifically) that are failing on some platforms and...

@Timer I can confirm that #19125 didn’t fix this, as I’m still seeing this issue on 10.0.3 :(

> Would be useful if you provide a reproduction for your particular case. I think the original reproduction from @cmwall attached to this issue represents my use case, but I...