controlsfx icon indicating copy to clipboard operation
controlsfx copied to clipboard
verified publisher icon controlsfx

Wizard API

Open wolftobias opened this issue 4 years ago • 2 comments

For the Wizard.java class, please make the dialog variable protected or provide a setter. Some people want to change some dialog properties e.g. window size, resizable or set a window icon. Now I even cannot subclass it!

wolftobias avatar Aug 31 '21 15:08 wolftobias

Can you provide a PR?

Maxoudela avatar Sep 21 '21 08:09 Maxoudela

Hi, I have been looking for a way to access the inner Dialog object of a Wizard, in my case to prevent it being modal. It seems that elevating Wizard's getDialog() method (currently package-private to allow it to be unit tested) to public would solve my issue as well as this one, and related issues #756, #976, #999.

A setDialog() method could be useful as well, but it would have to incorporate some of the code in Wizard's constructor, and I'm not sure how we would handle the possibility of it being called after the Wizard dialog had already been displayed.

Are you still happy to receive a PR for this? If so I will submit one for making getDialog() public, as I think that meets the need with the minimum of complication.

ianrenton avatar Feb 14 '24 13:02 ianrenton